llbuild: Prevent reported build tasks count from decreasing #7329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently SwiftPM will reduce the total number of jobs in the CLI output if llbuild determines a task does not need to be run. This results in confusing output to the user where as the build progresses the number of completed tasks strictly increases but the total can fluctuate. This commit updates the task counting logic to consider "up to date" build operations as complete instead of reducing the total count leading to clearer progress output.
rauhul
requested review from
bnbarham,
MaxDesiatov,
neonichu and
tomerd
as code owners
|
@swift-ci test |
MaxDesiatov
changed the title
MaxDesiatov
added
bug
build system
MaxDesiatov
reviewed
Feb 11, 2024
|
@swift-ci test linux |
MaxDesiatov
dismissed
their stale review
The change doesn't seem to have corresponding test cases that verify the desired behavior.
|
Tree pruning is pretty common in build systems (e.g. make, ninja). I think that the more confusing (and frustrating) aspect is the increasing target counts. |
Thats fine, but the fact that the total count first increases then decreases is pretty poor/confusing user experience. We could add a "skipped" count (which I actually plan on doing in a future PR) but that would not be "ninja" style output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently SwiftPM will reduce the total number of jobs in the CLI output if llbuild determines a task does not need to be run. This results in confusing output to the user where as the build progresses the number of completed tasks strictly increases but the total can fluctuate. This commit updates the task counting logic to consider "up to date" build operations as complete instead of reducing the total count leading to clearer progress output.