Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.10] Fix non-tarballed SDK installation with remote URL (#7312) #7321

Commits on Feb 5, 2024

  1. Fix non-tarballed SDK installation with remote URL (apple#7312)

    ### Motivation:
    
    4714ea9 introduced a regression where non-tarball SDKs could not be
    installed from a remote URL due to the wrong assumption that the
    downloaded file would always be a tarball.
    
    This issue exists in 5.10 release branch, so will cherry-pick after
    merging this PR.
    
    ### Modifications:
    
    This commit fixes the issue by checking the file extension part of the
    URL for every supported archive format, then falling back to the tarball
    format if no supported extension is found.
    
    ### Result:
    
    Non-tarball SDK artifact bundles can be installed from remote URL.
    kateinoigakukun committed Feb 5, 2024
    Copy the full SHA
    603471f View commit details
    Browse the repository at this point in the history