Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Enable -user-module-version for 6.0 #7263

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[main] Enable -user-module-version for 6.0 #7263

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be9d2ce
Enable `-user-module-version` for 5.10
MaxDesiatov Jan 17, 2024
7bcee9e
Change version to 5.11 in `SwiftTargetBuildDescription.swift`
MaxDesiatov Jan 19, 2024
8832b51
Update Sources/Build/BuildDescription/SwiftTargetBuildDescription.swift
MaxDesiatov Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion Sources/Build/BuildDescription/SwiftTargetBuildDescription.swift
View file
Open in desktop
Expand Up @@ -627,7 +627,12 @@ public final class SwiftTargetBuildDescription {
}

// Pass `-user-module-version` for versioned packages that aren't pre-releases.
if let version = package.manifest.version, version.prereleaseIdentifiers.isEmpty, version.buildMetadataIdentifiers.isEmpty, toolsVersion >= .vNext {
if
let version = package.manifest.version,
version.prereleaseIdentifiers.isEmpty &&
version.buildMetadataIdentifiers.isEmpty &&
toolsVersion >= .v5_11
MaxDesiatov marked this conversation as resolved.
Show resolved Hide resolved
{
args += ["-user-module-version", version.description]
}

Expand Down