Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.10] Enable -user-module-version for 5.10 #7261

Closed
wants to merge 1 commit into from

Conversation

MaxDesiatov
Copy link
Member

@MaxDesiatov MaxDesiatov commented Jan 17, 2024

Following up on #6795 (comment), cherry-pick of #7263.

  • Explanation: #if canImport(LibFoo, _version: "1.2.3") is not currently supported by SwiftPM, as this feature was gated on .vNext, even though it landed before SwiftPM 5.10 branched off.
  • Scope: Isolated to llbuild integration and packages that use swift-tools-version: 5.10, have a valid semantic version with no prerelease or build metadata identifiers.
  • Risk: Low. It's a source-compatible change that has been previously exposed to tests in SwiftPM - just passes user-module-version through.
  • Testing: Has a corresponding test in both release/5.10 and main already.
  • Issue: rdar://121124842
  • Reviewer: @neonichu on [main] Enable -user-module-version for 6.0 #7263

This was gated on `.vNext` previously, even though it was introduced before 5.10 branched off. It feels safe to enable this in 5.10.
@MaxDesiatov MaxDesiatov self-assigned this Jan 17, 2024
@MaxDesiatov MaxDesiatov added the swift 5.10 This PR targets the 5.10 branch label Jan 17, 2024
@MaxDesiatov
Copy link
Member Author

@swift-ci test

@MaxDesiatov
Copy link
Member Author

@swift-ci test windows

@MaxDesiatov MaxDesiatov changed the title Enable -user-module-version for 5.10 [5.10] Enable -user-module-version for 5.10 Jan 18, 2024
@MaxDesiatov
Copy link
Member Author

This didn't make it in time for 5.10

@MaxDesiatov MaxDesiatov deleted the maxd/user-module-version-5.10 branch January 19, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug swift 5.10 This PR targets the 5.10 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant