Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited installing swift index #649

Merged
merged 4 commits into from May 14, 2024
Merged

Conversation

RobinBateman808
Copy link
Collaborator

Motivation:

Help developers to get started with documentation.

Modifications:

Added user-friendly language and simple steps for clarity.

Result:

Provide new users and developers with an instructional vs functional approach.

@RobinBateman808
Copy link
Collaborator Author

RobinBateman808 commented May 2, 2024

@shahmishal, @federicobucchi - Made minor changes to this file that include numbered instructions and a user-friendly approach.

Copy link
Collaborator

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions

install/index.md Outdated Show resolved Hide resolved
install/index.md Outdated Show resolved Hide resolved
RobinBateman808 and others added 3 commits May 6, 2024 17:02
Co-authored-by: Tim Condon <[email protected]>
Co-authored-by: Tim Condon <[email protected]>
1. Simplified language at the end of step 1. 
2. Added clarifying wording to run the "command" in step 2.
@RobinBateman808
Copy link
Collaborator Author

Hi @shahmishal - please let me know if you have any changes. If it lgty, feel free to merge. Thanks!

Copy link
Collaborator

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will let @shahmishal take a look as well

@0xTim
Copy link
Collaborator

0xTim commented May 13, 2024

@swift-ci please test

@RobinBateman808
Copy link
Collaborator Author

@0xTim, @shahmishal - thank you!

@shahmishal shahmishal merged commit c88e87a into main May 14, 2024
1 check passed
@shahmishal shahmishal deleted the robins-installing-swift-changes branch May 14, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants