Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robins install swift changes #648

Merged
merged 5 commits into from May 15, 2024
Merged

Robins install swift changes #648

merged 5 commits into from May 15, 2024

Conversation

RobinBateman808
Copy link
Collaborator

Motivation:

Help developers get started using Swift.

Modifications:

Lightly edited "getting started > installing swift"

Result:

Help new users get started using swift from an instructional vs. functional approach.

@RobinBateman808
Copy link
Collaborator Author

@federicobucchi - these are very light changes to the page. Plmk if you have questions. Thanks!


Swift comes bundled with the [Swift Package Manager (SwiftPM)]({% link documentation/package-manager/index.md %}), which manages the distribution of your Swift code, and allows easy importing of other Swift packages into your apps.
Swift comes bundled with the [Swift Package Manager (SwiftPM)]({% link documentation/package-manager/index.md %}), which manages the distribution of your Swift code and allows easy importing of other Swift packages into your apps. SwiftPM is also used for managing dependencies in Swift server-side projects, command-line tools, and Swift scripts.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally this seems redundant:

SwiftPM is also used for managing dependencies in Swift server-side projects, command-line tools, and Swift scripts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Swift scripts" does not support SwiftPM today.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @bnbarham for SwiftPM review

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, removed Swift scripts language.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed redundancy.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahmishal - do you have further suggestions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahmishal - friendly reminder to review. Thank you! :-)

Copy link
Member

@federicobucchi federicobucchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a commend and LGTM

@0xTim
Copy link
Collaborator

0xTim commented May 15, 2024

@swift-ci please test

@0xTim 0xTim enabled auto-merge (squash) May 15, 2024 07:42
@0xTim 0xTim merged commit 30f092e into main May 15, 2024
1 check passed
@0xTim 0xTim deleted the robins-install-swift-changes branch May 15, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants