Add support for tags to blog posts #503
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds simple tag bubbles that can be added to blog posts. In the future we may want to make these selectable for filtering and include a search bar as was done for swift-evolution.
rauhul
requested review from
cthielen,
TimTr,
tkremenek,
tomerd,
0xTim,
alexandersandberg,
daveverwer,
dempseyatgithub,
parispittman,
kaishin,
mschinis and
shahmishal
as code owners
|
I tried to do this with a new |
|
related to #98 |
|
@swift-ci please test |
|
@shahmishal can I get a review on this? |
|
The website workgroup discussed this topic last week, and it's a great idea. The next steps:
@dempseyatgithub had previously worked on identifying each blog post; he was planning on digging up old notes. |
I think it would be good to handle this in a subsequent PR, I'm not a web dev and It might take me (or anyone else) some time to implement that feature. I think the tags have value without having search immediately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds simple tag bubbles that can be added to blog posts. In the future we may want to make these selectable for filtering and include a search bar as was done for swift-evolution.
Before:
After:
