Repository navigation
Conversation
gakiwate
commented
Nov 13, 2026
gakiwate
commented
Contributor
- orderEndpoints takes a destination comparator, a connection-use reader and a randomness source; each defaults to a built-in or a no-op.
- Add PriorityOrigin: a priority of 0 means "none supplied" for a service binding, and the most preferred value for SRV.
- Add orderBySRVWeight, the RFC 2782 weight-proportional draw within each priority group.
- Add preferConnectedOrder, moving the endpoint with the most established use to the front.
- Endpoint.priority and .weight gain setters.
- Default Preferred Address Family Count is now 2.
- Move the IPv6 prefix predicates to IPv6Address.swift.
- orderEndpoints takes a destination comparator, a connection-use reader and a randomness source; each defaults to a built-in or a no-op. - Add PriorityOrigin: a priority of 0 means "none supplied" for a service binding, and the most preferred value for SRV. - Add orderBySRVWeight, the RFC 2782 weight-proportional draw within each priority group. - Add preferConnectedOrder, moving the endpoint with the most established use to the front. - Endpoint.priority and .weight gain setters. - Default Preferred Address Family Count is now 2. - Move the IPv6 prefix predicates to IPv6Address.swift.
gakiwate
requested review from
agnosticdev,
ekinnear and
tfpauly
as code owners
November 13, 2026 19:55
tfpauly
reviewed
Nov 13, 2026
|
|
||
| // MARK: Grouping by application protocol and security requirements | ||
|
|
||
| // Not implemented: no endpoint carries ALPN values or security parameters. Its groups are |
Collaborator
There was a problem hiding this comment.
I don't think should remain "not implemented", but should instead be passed in by the caller when it is known.
Contributor
Author
There was a problem hiding this comment.
Addressed it. We now have a ProtocolGroupRanker function that gets passed in similar to the others.
- Add protocolGroups and orderEndpointGroups. Groups are alternatives, so they are returned as separate lists rather than one, and an endpoint usable over two protocols is offered in both. - Run the SRV weighted draw before prefer-connected, which moves an entry to the front and would otherwise split the contiguous priority runs the draw reads. - An endpoint with no IP family, a Unix-domain one included, holds its slot instead of disqualifying its whole run from interleaving. - Name the default Preferred Address Family Count as a constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.