FoundationEssentials: implement file operations #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkera
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
I'll leave the detailed review to @jmschonfeld but this looks good to me. Thanks for taking on this porting work @compnerd!
jmschonfeld
reviewed
Apr 29, 2024
jmschonfeld
approved these changes
Apr 29, 2024
|
@swift-ci please test |
These build failures do look related - it looks like this change breaks the macOS/linux build. Let me know if you need any assistance addressing that before we merge this |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
This adds an initial implementation for file operations on Windows. With this, `FileManager` should at least build on Windows, which unblocks future work as well as brings us closer to enabling `FoundationEssentials` on Windows.
|
@swift-ci please test |
|
Going to merge this for now - if there are any more comments, happy to address them in a follow up. This should allow us to get to the file diffing changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an initial implementation for file operations on Windows. With this,
FileManagershould at least build on Windows, which unblocks future work as well as brings us closer to enablingFoundationEssentialson Windows.