Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FoundationEssentials: implement file diffing support for Windows #548

Merged
merged 2 commits into from Apr 30, 2024
Merged

FoundationEssentials: implement file diffing support for Windows #548

merged 2 commits into from Apr 30, 2024

Conversation

compnerd
Copy link
Collaborator

Windows does not have the same Unix file system APIs (e.g. FTS). Implement a platform specific implementation to compare files on Windows.

@compnerd
Copy link
Collaborator Author

@swift-ci please test

@compnerd
Copy link
Collaborator Author

@swift-ci please test

@compnerd
Copy link
Collaborator Author

@swift-ci please test

@compnerd
Copy link
Collaborator Author

@jmschonfeld anything holding this up?

@compnerd
Copy link
Collaborator Author

@parkera @jmschonfeld - would be nice to get this going. There are a few pending changes for FileManager and one that I am still working on. The sum of those would however seem to be sufficient to build FileManager on Windows. That would allow me to focus on the next few items blocking building FoundationEssentials on Windows. Although that would still not allow the full package to build, it would be a great milestone.

@compnerd
FoundationEssentials: repair the Windows build after tweaks
a3ca871 
The changes to repair the macOS/Linux build adversely impacted the
Windows build. Accommodate the API and logic changes for Windows.
@compnerd
Copy link
Collaborator Author

@swift-ci please test

@compnerd
FoundationEssentials: implement file diffing support for Windows
713c0dd 
Windows does not have the same Unix file system APIs (e.g. FTS).
Implement a platform specific implementation to compare files on
Windows.
@compnerd
Copy link
Collaborator Author

@swift-ci please test

jmschonfeld
jmschonfeld approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@jmschonfeld jmschonfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating on this, this looks good to me!

@compnerd compnerd merged commit 6c151ca into apple:main Apr 30, 2024
2 checks passed
@compnerd compnerd deleted the diff branch April 30, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmschonfeld jmschonfeld jmschonfeld approved these changes

@parkera parkera Awaiting requested review from parkera

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@compnerd @jmschonfeld