Swift testing proof of concept #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
iCharlesHu
reviewed
Nov 14, 2023
| @@ -19,17 +19,16 @@ import TestSupport | |||
| #endif | |||
|
|
|||
| final class BufferViewTests: XCTestCase { | |||
There was a problem hiding this comment.
Since this is a proof of concept, could you fully adopt swift-testing for this file? For example, we should switch to using @Suite and @Testing etc with a struct and avoid using XCTestCase directly.
Comment on lines
+22
to
+24
| func testAll() async { | ||
| await XCTestScaffold.runAllTests(hostedBy: self) | ||
| } |
There was a problem hiding this comment.
This should be in it's own file so other swift-testing tests can use it as well.
|
Thanks @aleksproger for this - we are pushing forward on this in future PRs and also working through the cyclical dependency in swift-foundation <-> swift-testing. |
|
( #545 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift-testingBufferViewTeststoswift-testingas a showcaseswift-testingrequires 5.10 toolchain to work, so theswift-foundationtoolchain then should be bumped accordingly