Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Change DateComponent's storage layout #206

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] Change DateComponent's storage layout #206

wants to merge 1 commit into from

Conversation

Azoy
Copy link
Member

@Azoy Azoy commented Jul 19, 2023

This is still marked as a WIP because I need to add tests to exercise all of the various branches this can take. This does pass the current preview tests.

@hassila hassila mentioned this pull request Nov 7, 2023
Open
@naknut
Copy link
Contributor

naknut commented Mar 20, 2024

Hi @Azoy! I just posted in #302. I was thinking this could be a good first issue for me to contribute to. Do you still feel like this is a reasonable solution? If so I asked some questions in the issue on how to move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkera parkera Awaiting requested review from parkera

@lorentey lorentey Awaiting requested review from lorentey

@jmschonfeld jmschonfeld Awaiting requested review from jmschonfeld

@iCharlesHu iCharlesHu Awaiting requested review from iCharlesHu

@itingliu itingliu Awaiting requested review from itingliu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Azoy @naknut