Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FoundationEssentials: add RawRepresentable conformance to `_ErrorCo… #149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

compnerd
Copy link
Collaborator

…deProtocol`

The Self constraint suggests that the protocol provide a RawRepresentable conformance. Silence the compiler warning by adding the conformance.

…deProtocol`

The `Self` constraint suggests that the protocol provide a
`RawRepresentable` conformance.  Silence the compiler warning by adding
the conformance.
@parkera
Copy link
Member

parkera commented May 30, 2023

I actually tried to fix this too, but it causes an ABI breakage on Darwin. I'm not sure it's possible to compatibly add a requirement to a protocol like this.

@compnerd
Copy link
Collaborator Author

@parkera oh, interesting. I wonder if we can add the conformance conditionally?

@parkera
Copy link
Member

parkera commented May 30, 2023

I think it boils down to a new requirement that would be imposed upon anyone who adopts this (outside the framework), which we don't have any mechanism to enforce. I could be wrong though.

@iCharlesHu
Copy link
Contributor

@swift-ci please test macOS

@parkera
Copy link
Member

parkera commented Sep 18, 2023

@compnerd any idea what we can do about this one, given the ABI break?

@compnerd
Copy link
Collaborator Author

I need to try to build this again to remember what is going on here; I wonder if the constraint might be something that we need on the typealias? But either way, the new constraint is the issue. I'm not sure if there is a way to adopt this type without that, but at the same time, we don't have a way to silence the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants