[6.0] Schedule an emit-module-separately job even if an input is not compilable #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able The following invocation should schedule an emit-module-separately job for src.swift and include other.dylib in the link job. ``` swiftc -emit-library src.swift other.dylib ``` rdar://127238278
Fixes the failure in testDependencyScanningPathRemap.
|
@swift-ci Please test |
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
approved these changes
May 1, 2024
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following invocation should schedule an emit-module-separately job for src.swift and include other.dylib in the link job. This fixes an issue that would make the compiler instead schedule a deprecated merge-module job.
Risk: Low, not many clients use this path and emit-module-separately is more reliable than merge-module.
Scope: Projects calling the driver as an executable from cmake.
Reviewed by @artemcm
Cherry-pick of #1588
Resolves rdar://127238278