Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't normalize *-unknown-windows-coff as *-unknown-windows-msvc #1558

Merged
merged 1 commit into from Mar 12, 2024

Commits on Mar 10, 2024

  1. Don't normalize *-unknown-windows-coff as *-unknown-windows-msvc

    This fixes the inability to use `x86_64-unknown-windows-coff` and `i686-unknown-windows-coff` triples with Embedded Swift.
    
    *Steps to reproduce:*
    
    1. Install latest development snapshot off `main`, e.g. `swift-DEVELOPMENT-SNAPSHOT-2024-03-01-a-osx`.
    2. Try to build with `swiftc -target i686-unknown-windows-coff -enable-experimental-feature Embedded -wmo -c test.swift`
    
    *Expected result:*
    
    Code compiles successfully or an actionable diagnostic message is produced.
    
    *Actual result:*
    
    <unknown>:0: error: could not find module 'Swift' for target 'i686-unknown-windows-msvc'
    MaxDesiatov committed Mar 10, 2024
    Copy the full SHA
    e1fcf14 View commit details
    Browse the repository at this point in the history