Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.0] Don't suggest bundle name as possible replacement for symbol links (#900) #902

Merged
merged 2 commits into from May 3, 2024
Merged

[6.0] Don't suggest bundle name as possible replacement for symbol links (#900) #902

merged 2 commits into from May 3, 2024

Conversation

d-ronnqvist
Copy link
Contributor

  • Explanation: This fixes a confusing error message that can happen for misspelled links to the module (for example when creating a top-level documentation extension file) when the documentation catalogs Info.plist file specifies a slight misspelling of the module name for the project's "bundle name".
  • Scope: Confusing error message.
  • Issue: rdar://125964139
  • Risk: Low.
  • Testing: Added unit test.
  • Reviewer: @sofiaromorales
  • Original PR: Don't suggest bundle name as possible replacement for symbol links #900

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist d-ronnqvist merged commit e2110cc into apple:release/6.0 May 3, 2024
2 checks passed
@d-ronnqvist d-ronnqvist deleted the no-symbol-link-suggestion-for-bundle-name-6.0 branch May 3, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Teapane Teapane Teapane approved these changes

@franklinsch franklinsch Awaiting requested review from franklinsch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@d-ronnqvist @Teapane