Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few issues with infinite recursions if the content contains cyclic curation #898

Merged
merged 15 commits into from
Apr 29, 2024
Merged

Fix a few issues with infinite recursions if the content contains cyclic curation #898

merged 15 commits into from
Apr 29, 2024

Commits on Apr 23, 2024

  1. Add functions to operate on directed graphs

    @d-ronnqvist
    d-ronnqvist committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    bd6cfb6 View commit details
    Browse the repository at this point in the history

  2. Update topic graph to use sequences for graph traversal

    @d-ronnqvist
    d-ronnqvist committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    dca31c1 View commit details
    Browse the repository at this point in the history

  3. Avoid computing full paths to determine if a symbol is manually curated

    @d-ronnqvist
    d-ronnqvist committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    07181eb View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Fix an infinite recursion determining the paths to a node when there'… 

    …s cyclic curation

rdar://126974763
    @d-ronnqvist
    d-ronnqvist committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    4307c4e View commit details
    Browse the repository at this point in the history

  2. Avoid computing all paths when the caller only needs the shortest path

    @d-ronnqvist
    d-ronnqvist committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    be1edf5 View commit details
    Browse the repository at this point in the history

  3. Avoid computing all paths when the caller only needs the roots/leaves

    @d-ronnqvist
    d-ronnqvist committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1bb242f View commit details
    Browse the repository at this point in the history

  4. Avoid computing all paths when the caller only needs know if a certai… 

    …n node is encountered
    @d-ronnqvist
    d-ronnqvist committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    598abf3 View commit details
    Browse the repository at this point in the history

  5. Avoid computing all paths when the caller only needs to visit each re… 

    …achable node once
    @d-ronnqvist
    d-ronnqvist committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    4572d0f View commit details
    Browse the repository at this point in the history

  6. Rename 'pathsTo(_:options:)' to 'finitePaths(to:options:)

    @d-ronnqvist
    d-ronnqvist committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    6bac023 View commit details
    Browse the repository at this point in the history

  7. Fix another infinite recursion when pages are curated in cycles 

    rdar://126974763
    @d-ronnqvist
    d-ronnqvist committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    82cc806 View commit details
    Browse the repository at this point in the history

  8. Fix correctness issue where symbol has two auto curated parents

    @d-ronnqvist
    d-ronnqvist committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    7ecdc10 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into fix-infinite-recursions

    @d-ronnqvist
    d-ronnqvist committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    3416c99 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Merge branch 'main' into fix-infinite-recursions

    @d-ronnqvist
    d-ronnqvist committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    4b7d98d View commit details
    Browse the repository at this point in the history

  2. Address code review feedback: 

    - Rename neighbors parameter to edges for DirectedGraph initializer
- Rename GraphPathIterator and move it to DirectedGraph+Paths file
- Add convenience properties for topic graph directed graph "views
- Elaborate on breadcrumbs path documentation and implementation comments
- Elaborate on graph cycle documentation with concrete examples
- Fix missing edge in directed graph test data
- Use preconditionFailure for topic graph node that should always exist
- Add additional graph cycle tests
    @d-ronnqvist
    d-ronnqvist committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    229c2ed View commit details
    Browse the repository at this point in the history

  3. Explicitly exit (trap) if trying to dump a topic graph with cyclic paths

    @d-ronnqvist
    d-ronnqvist committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    421f9fe View commit details
    Browse the repository at this point in the history