[6.0] Check for aligned_alloc() and use posix_memalign() instead on platforms that don't have it
#827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tforms, like Android before API 28, that didn't have it
|
Hold off on this, may need to pull in #826 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Android before API 28 didn't have
aligned_alloc(), so this simply brings back the code that was replaced in #805 for platforms like that.Scope: Three small changes to bring back previously working code, where needed
Issue: None
Original PR: #811
Risk: None, this just brings back working code for a few platforms
Testing: Passed all CI on trunk, plus on my daily Android CI
Reviewer: @compnerd