[wasm] Define _WASI_EMULATED_MMAN to replace imports
#4913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
IIUC |
Importing `wasi_emulated_mman` in Swift code requires the client to define `_WASI_EMULATED_MMAN`. `@_implementationOnly import` was the only way to work around this, but it's now declared as unsafe if it's used in non-resilient moules (even though it's actually safe as long as the module does not use type layout of the imported module). The new scoped import feature always requires the transitive clients to load privately imported modules, so it's not a good fit for this tricky case where a special macro must be defined before importing the module. This patch imports `sys/mman.h` through CoreFoundation while defining `_WASI_EMULATED_MMAN` in the header exposed by modulemap. This way, the clients don't need to define it.
kateinoigakukun
force-pushed
the
pr-f6022e0721b057fdae9a44e9299afba97392ce2d
branch
from
2a8ed98
to
90c1832
Compare
|
@MaxDesiatov Updated not to use |
MaxDesiatov
approved these changes
Mar 8, 2024
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
changed the title
wasi_emulated_mman with @_implementationOnly_WASI_EMULATED_MMAN in headers instead of using imports
MaxDesiatov
changed the title
_WASI_EMULATED_MMAN in headers instead of using imports_WASI_EMULATED_MMAN to replace imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
wasi_emulated_mmanmodule must be imported with@_implementationOnlyto avoid requiring Foundation users to enable_WASI_EMULATED_MMANby themselves. "private import" does not work here because it still imports private dependencies while building a module that import Foundation.