[wasm] Provide stub for _NSCreateTemporaryFile on WASI
#4896
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
MaxDesiatov
reviewed
Mar 2, 2024
| return (fd, pathResult) | ||
| #endif |
There was a problem hiding this comment.
this change seems to be impacting non-WASI #if branch?
There was a problem hiding this comment.
The return (fd, pathResult) line was shared among all cases, but it's now cloned into os(Windows) and !os(Windows) && !os(WASI) cases. So there is no semantic change.
MaxDesiatov
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WASI does not have temp directories and wasi-libc does not provide
mkstemp, so provide a stub implementation that throwsENOTSUP.