Foundation: repair the build for Android API level 28+ #4889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
I have a similar pull submitted months ago, #4850, that simply has not been reviewed, which only doesn't have your |
The newer level introduces APIs with additional nullability attribution. This causes issues as the attribution sometimes collides with expectations. Unwrap more cases to appease the nullability attributes. One problematic area of this change is the handling for `Process.run()`. The posix spawn APIs are described as: ``` typedef struct __posix_spawnattr* posix_spawnattr_t; int posix_spawnattr_init(posix_spawnattr_t _Nonnull * _Nonnull __attr); ``` As the inner `_Nonnull` appertains to `posix_spawnattr_t`, it expects a non-null pointer to a non-null pointer. However, as `struct __posix_spawnattr` is opaque, we cannot allocate space for it and thus must be acceptable to take a pointer to null to permit the allocation.
|
@swift-ci please test |
|
Oh, nice, I was just going to try building this repo natively on Android with your recent compiler pulls, will apply your Glibc-replacing changes here. I also need to reconcile my earlier pull #4850 for the nullability annotations in NDK 26 with Saleem's first commit here, will try to get to that this week. |
finagolfin
reviewed
May 1, 2024
| @usableFromInline let free = Android.free | ||
| @usableFromInline let memset = Android.memset | ||
| @usableFromInline let memcpy = Android.memcpy | ||
| @usableFromInline let memcmp = Android.memcmp |
There was a problem hiding this comment.
Trying to build with this commit now, looks like you missed an import Android 17 lines below this block.
finagolfin
reviewed
May 1, 2024
| @@ -25,6 +25,10 @@ import WinSDK | |||
| import WASILibc | |||
| #endif | |||
|
|
|||
| #if os(Android) | |||
finagolfin
reviewed
May 1, 2024
| @@ -13,6 +13,7 @@ import WinSDK | |||
| #endif | |||
|
|
|||
| #if os(Android) | |||
finagolfin
reviewed
May 1, 2024
| @@ -13,6 +13,7 @@ import WinSDK | |||
| #endif | |||
|
|
|||
| #if os(Android) | |||
| import Android | |||
| // Android Glibc differs a little with respect to the Linux Glibc. | |||
There was a problem hiding this comment.
Android Glibc -> Android Bionic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newer level introduces APIs with additional nullability attribution. This causes issues as the attribution sometimes collides with expectations. Unwrap more cases to appease the nullability attributes. One problematic area of this change is the handling for
Process.run(). The posix spawn APIs are described as:As the inner
_Nonnullappertains toposix_spawnattr_t, it expects a non-null pointer to a non-null pointer. However, asstruct __posix_spawnattris opaque, we cannot allocate space for it and thus must be acceptable to take a pointer to null to permit the allocation.