Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make _MultiHandle timeout timer non-repeatable #4858

Merged
merged 1 commit into from
May 25, 2024

Commits on Dec 25, 2023

  1. Make _MultiHandle timeout timer non-repeatable

    CURL documentation (https://curl.se/libcurl/c/CURLMOPT_TIMERFUNCTION.html)
    explicitly says that the timer should be one-time. We basically have to
    follow CURL requests for setting, resetting and disarming such timers.
    
    Current logic eventually leaves a 1ms repeating timer forever, because
    CURL assumes it fires once, and may not ask us to remove it explicitly.
    
    Also, being used as request timeout trigger, this timer also has no sense
    to be repeated.
    lxbndr committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    7258a8d View commit details
    Browse the repository at this point in the history