Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust filename according to style guide #484

Merged
merged 2 commits into from May 13, 2024
Merged

Adjust filename according to style guide #484

merged 2 commits into from May 13, 2024

Conversation

garysassano
Copy link
Contributor

Adjusted template's filename in tutorial's example to reflect Pkl Style Guide recommendations.

bioball
bioball reviewed May 9, 2024
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
bioball
bioball requested changes May 9, 2024
View reviewed changes
Copy link
Contributor

@bioball bioball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the typo fixes! There's a .vscode/settings.json file that shouldn't be checked in, though.

@garysassano garysassano requested a review from bioball May 12, 2024 11:53
bioball
bioball approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@bioball bioball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@bioball bioball merged commit 2d31bc5 into apple:main May 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bioball bioball bioball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@garysassano @bioball