Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] LLDB CMake: add option to link Swift content from Darwin toolchain #8648

Conversation

edymtt
Copy link

@edymtt edymtt commented Apr 28, 2024

Explanation: introduce a CMake option that allow LLDB binaries to link against Swift content in Darwin toolchains -- this is neeed by Apple internal configurations
Radar: rdar://127113448
Scope: CMake build logic that configure the build for LLDB binaries on Darwin platforms
Risk: low -- this behaviour is opt in
Testing:

  • CI testing

Reviewed By: @JDevlieghere in #8647

This is a companion to apple/swift#73255, and
it's needed in some Apple internal configurations.

Addresses rdar://127113448

(cherry picked from commit 842763b)
@edymtt
Copy link
Author

edymtt commented Apr 28, 2024

@swift-ci Please test

@edymtt
Copy link
Author

edymtt commented Apr 28, 2024

@swift-ci test llvm

@edymtt
Copy link
Author

edymtt commented Apr 28, 2024

LLVM Test jobs are failing when running lit tests

Failed Tests (5):
  Clang :: Driver/lanai-unknown-unknown.cpp
  Clang :: Driver/mipsel-nacl-defines.cpp
  Clang :: Driver/wasm32-unknown-unknown.cpp
  Clang :: Driver/wasm64-unknown-unknown.cpp
  Clang :: Driver/x86_64-nacl-defines.cpp

Cannot find readily any baseline reference (since most PRs targeting swift/release/6.0 focus on the Swift testing), so not considering them blocking.

@shahmishal shahmishal merged commit 83823fd into apple:swift/release/6.0 Apr 29, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants