Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update code and method annotation #82

Merged
merged 8 commits into from May 4, 2024
Merged

fix: update code and method annotation #82

merged 8 commits into from May 4, 2024

Conversation

hakusai22
Copy link
Contributor

@hakusai22 hakusai22 commented Apr 13, 2024 •
edited

  1. Use is instead of == to check if a variable is None.
  2. Method parameter annotation modification.
  3. apple documentation link updates and additions.
  4. word typo.

@hakusai22 hakusai22 changed the title Update code and Method annotation fix: update code and method annotation Apr 30, 2024
alexanderjordanbaker
alexanderjordanbaker approved these changes May 4, 2024
View reviewed changes
Copy link
Collaborator

@alexanderjordanbaker alexanderjordanbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! I'll be bringing over the doc updates to the other three languages based on this. I think, besides the typos, we didn't originally list the link on a List of items, but I agree it makes the most sense to put the link in there.

@alexanderjordanbaker alexanderjordanbaker merged commit 982919f into apple:main May 4, 2024
5 checks passed
alexanderjordanbaker added a commit to alexanderjordanbaker/app-store-server-library-java that referenced this pull request May 4, 2024
@alexanderjordanbaker
Add URL links to docs for items that are a List
f7e3f41 
Adding for same fields as apple/app-store-server-library-python#82
@alexanderjordanbaker alexanderjordanbaker mentioned this pull request May 4, 2024
Merged
alexanderjordanbaker added a commit to alexanderjordanbaker/app-store-server-library-node that referenced this pull request May 4, 2024
@alexanderjordanbaker
Add URL links to docs for items that are a List
c9400f1 
Adding for same fields as apple/app-store-server-library-python#82
@alexanderjordanbaker alexanderjordanbaker mentioned this pull request May 4, 2024
Merged
alexanderjordanbaker added a commit to alexanderjordanbaker/app-store-server-library-swift that referenced this pull request May 4, 2024
@alexanderjordanbaker
Add URL links to docs for items that are a List
c8ea4fe 
Adding for same fields as apple/app-store-server-library-python#82
alexanderjordanbaker added a commit to alexanderjordanbaker/app-store-server-library-swift that referenced this pull request May 4, 2024
@alexanderjordanbaker
Add URL links to docs for items that are a List
f89c61e 
Adding for same fields as apple/app-store-server-library-python#82
@alexanderjordanbaker alexanderjordanbaker mentioned this pull request May 4, 2024
Merged
@hakusai22 hakusai22 deleted the fix_codestyle_desc branch May 4, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderjordanbaker alexanderjordanbaker alexanderjordanbaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hakusai22 @alexanderjordanbaker