requires edit permission to import #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boutell
requested changes
Jan 31, 2024
boutell
requested changes
Feb 1, 2024
test/index.js
Outdated
| @@ -23,6 +23,16 @@ describe('@apostrophecms/import-export', function () { | |||
| after(async function() { | |||
| await cleanData([ attachmentPath, exportsPath ]); | |||
| await t.destroy(apos); | |||
|
|
|||
| apos = null; | |||
There was a problem hiding this comment.
This block runs once "after" the entire thing right? In that case it is unnecessary to manually reset these properties because these variables fall out of scope when the closure goes away after the last test. Unless I'm missing something?
boutell
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PRO-5564
What are the specific steps to test this change?
It requires the edit permission to see the import utility operation
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: