Test coverage for the @ syntax of PATCH when applied to area ids#5298
Open
Test coverage for the @ syntax of PATCH when applied to area ids#5298
Conversation
myovchev
requested changes
Feb 2, 2026
Contributor
myovchev
left a comment
myovchev
left a comment
There was a problem hiding this comment.
Just a little refactoring for consistency with the "non-dependent" test standards (raised some time ago). There are also 2 eslint problems to be fixed.
| await apos.user.insert(apos.task.getReq(), user); | ||
| }); | ||
|
|
||
| it('should be able to login as admin', async function() { |
Contributor
There was a problem hiding this comment.
This should be part of the before hook. The rest of the tests shouldn't depend on any other test. before in this case is fine because there is no reset between tests (otherwise beforeEach would be more appropriate)
| }); | ||
| }); | ||
|
|
||
| it('should be able to upload an image and create an image piece', async function() { |
Contributor
There was a problem hiding this comment.
Same here. This is just state used by other tests, in this case before is the right place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out it works fine, but the test is healthy to have. Created with claude code.