Fix: Edit button fails to open image editor for attachments not in visible page#5160
Open
rithigavijayendran wants to merge 1 commit intoapostrophecms:mainfrom
Open
Fix: Edit button fails to open image editor for attachments not in visible page#5160rithigavijayendran wants to merge 1 commit intoapostrophecms:mainfrom
rithigavijayendran wants to merge 1 commit intoapostrophecms:mainfrom
Conversation
…e on current page
boutell
requested changes
Nov 19, 2025
Member
boutell
left a comment
boutell
left a comment
There was a problem hiding this comment.
Would you please clarify how this change works? My first impression is that nothing in ApostropheCMS would discover or use this component if installed, but perhaps I have missed something. I don't believe we have any such mechanism to automatically discover such a component or that would invoke such a method if it were found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the “Edit” button in the media manager fails to open the
image editor if the selected image is not included in the currently loaded
page of results.
Root Cause
The
openImageEditormethod was only executed when the image existed in theloadedImagesarray. When the selected image was on page 2+ of the mediamanager, this condition failed, preventing the editor dialog from opening.
Fix
Override the module's UI component (
ManagerModal.vue) and ensure thatopenImageEditoralways emits theopen-editorevent with the correctattachment ID.
Files Added