Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center widget tab text #4532

Merged
merged 2 commits into from May 17, 2024
Merged

Center widget tab text #4532

merged 2 commits into from May 17, 2024

Conversation

BoDonkey
Copy link
Contributor

@BoDonkey BoDonkey commented May 9, 2024

Summary

Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"
According to the design (and Stu), text should be centered in the tabs. Currently, text was left-justified and this is most noticeable when a label is displayed on two lines. This PR changes the CSS to center align the text. Closes PRO-6048

What are the specific steps to test this change?

For example:

  1. Run the website and log in as an admin
  2. Open a piece manager modal and select several pieces
  3. Click the "Archive" button on the top left of the manager and confirm that it should proceed
  4. Check that all pieces have been archived properly
  1. Add a widget group with a long label.
  2. Check that the text is centered for both lines.

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@BoDonkey BoDonkey requested a review from ETLaurent May 9, 2024 14:32
ETLaurent
ETLaurent previously approved these changes May 13, 2024
@BoDonkey BoDonkey requested a review from ETLaurent May 13, 2024 13:55
@boutell boutell requested review from boutell and removed request for ETLaurent May 17, 2024 13:31
@BoDonkey BoDonkey merged commit cf06520 into main May 17, 2024
8 checks passed
@BoDonkey BoDonkey deleted the PRO-6048-style-tab branch May 17, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants