-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pro 4257 modal operation #4251
Pro 4257 modal operation #4251
Conversation
PRO-4257 As a developer, I can use the modal property in my batch operations
Like for the method
This way, when clicking on the batch operation button, will be able to open a specific modal for more specific and complex behaviors. We'll need this feature to be able to open the same export modal when clicking on the You can base your work on the way it works currently for the Acceptance Criteria
|
modules/@apostrophecms/doc-type/ui/apos/components/AposDocContextMenu.vue
Outdated
Show resolved
Hide resolved
modules/@apostrophecms/modal/ui/apos/components/AposDocsManagerToolbar.vue
Outdated
Show resolved
Hide resolved
modules/@apostrophecms/piece-type/ui/apos/components/AposDocsManager.vue
Show resolved
Hide resolved
* main: (24 commits) Pro 4257 modal operation (#4251) Add request information when possible fixed tests eslint fix context operation module names Legacy util logger note CHANGELOG Dev docs env clarification Remove object assign for performance add missing keys add settings translations More performance Kill mongo warning Login structured logging Implement route errors Assign shorthand Performance optimization API errors draft Property order Handle messageAs and legacy log calls ...
Summary
Add the ability to have custom modals for batch operations, and align props between doc context menu custom modal and batch operation custom modal, in order to use the same component.
What are the specific steps to test this change?
Test with apostrophecms/import-export#2
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements: