Skip to content

Conversation

@aaronArinder
Copy link
Contributor


docs pending a conversation with the response caching folks, but this part of a customer's use-case that I'd like to make sure sticks around (they do a bit of business analysis with what's in their cache, via a coprocessor talking to the cache using the cache keys)

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@aaronArinder aaronArinder requested a review from a team as a code owner December 4, 2025 17:51
@apollo-librarian
Copy link

apollo-librarian bot commented Dec 4, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed
* graphos/routing/(latest)/observability/router-telemetry-otel/enabling-telemetry/instruments.mdx

Build ID: 5625156bfbe983dcbbe1ddb0
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/5625156bfbe983dcbbe1ddb0

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

@aaronArinder, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

Copy link
Contributor

@carodewig carodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great call to add a test for this to ensure the behavior is included going forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants