Library metadata: push changes to main branch instead of creating separate pr #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
reviewed
Dec 9, 2025
| run: | | ||
| gh pr create -B main -H metadata_updates --title 'docs: subgraph library metadata updates' --body 'Created by Github Action' | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Member
There was a problem hiding this comment.
You will definitely need to pass GITHUB_TOKEN with proper permissions. Instead of doing direct merge to main - should we open a PR and auto-merge it if it was opened by a known user and all tests pass?
Author
There was a problem hiding this comment.
We'd still need to press the "Enable automerge" on the PR I think? I can't find a way to do it automatically without human intervention.
Member
There was a problem hiding this comment.
I think you could use gh pr merge (this enables auto merge on the PR and/or merges it if there are no outstanding pending checks) -> https://cli.github.com/manual/gh_pr_merge
Member
There was a problem hiding this comment.
i.e. lets try reverting your changes and add (🤞 token has right permissions)
- name: Enable auto merge PR
run: |
gh pr merge
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not quite sure how to test this without merging 😓