Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GitHub workflow to automatically run tests #64 #72

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

Harman-Aalto
Copy link
Contributor

-Added Dolos as submodule
-Modified how to compare matches:

  • Created a new Django command 'recompare' to compare matches without using the "Recompare all" or the "Recompare all exercises with unmatched submissions" button

  • In exercise settings "Recomparing all submissions" now recompares without needing the CLI command 'matchsubmissions'

  • In course page "Recompare all exercises with unmatched submissions" now recompares without needing the CLI command 'matchsubmissions'

-Added Python submissions for testing Radar
-Updated README.md for how to compare matches

Description

What?

Created a yml file to automate tests in GitHub Worflow.

Why?

To automate tests.

How?

Followed how it was done in A+.

Fixes #64

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

Tests ran on GitHub workflow.

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

@mikaelGusse
Copy link
Contributor

This is wonderful! Just one small thing that I think needs an additional if check but otherwise OK to merge.

-Added Dolos as submodule
-Modified how to compare matches:
 -Created a new Django command 'recompare' to compare matches without using the "Recompare all" or the "Recompare all exercises with unmatched submissions" button
  -In exercise settings "Recomparing all submissions" now recompares without needing the CLI command 'matchsubmissions'
   -In course page "Recompare all exercises with unmatched submissions" now recompares without needing the CLI command 'matchsubmissions'
-Added Python submissions for testing Radar
-Updated README.md for how to compare matches
@Harman-Aalto Harman-Aalto merged commit d0f2013 into apluslms:master Jan 28, 2025
3 checks passed
@Harman-Aalto Harman-Aalto deleted the issue64 branch January 28, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create GitHub workflow to automatically run tests
2 participants