Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fixed rate compression extensions #913

Merged
merged 4 commits into from
May 30, 2024

Conversation

lfrb
Copy link
Contributor

@lfrb lfrb commented Apr 25, 2024

This adds support for:

  • GL_EXT_EGL_image_storage_compression
  • GL_EXT_texture_storage_compression
  • EGL_EXT_surface_compression

Copy link
Member

@jrfonseca jrfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good. Thanks

specs/eglapi.py Outdated
@@ -434,6 +454,9 @@ def GlFunction(*args, **kwargs):
GlFunction(Void, "glEGLImageTargetTexture2DOES", [(GLenum, "target"), (EGLImageKHR, "image")]),
GlFunction(Void, "glEGLImageTargetRenderbufferStorageOES", [(GLenum, "target"), (EGLImageKHR, "image")]),

# EGL_EXT_surface_compression
GlFunction(EGLBoolean, "eglQuerySupportedCompressionRatesEXT", [(EGLDisplay, "dpy"), (EGLConfig, "config"), (EGLWindowSurfaceAttribs, "attrib_list"), Out(Array(EGLint, "*num_rates"), "rates"), (EGLint, "rate_size"), Out(Pointer(EGLint), "num_rates")]),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sideeffects=False

@jrfonseca
Copy link
Member

I think you need to rebase and add the sideeffects=False, otherwise looks ready to go.

lfrb added 4 commits May 30, 2024 09:19
Signed-off-by: Louis-Francis Ratté-Boulianne <[email protected]>
Signed-off-by: Louis-Francis Ratté-Boulianne <[email protected]>
Signed-off-by: Louis-Francis Ratté-Boulianne <[email protected]>
@jrfonseca jrfonseca merged commit 1807d6a into apitrace:master May 30, 2024
10 checks passed
@jrfonseca
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants