feat: add Book resource #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinceAmstoutz
requested changes
Feb 8, 2025
Comment on lines
+16
to
+19
| #[ApiProperty(property: 'title', serialize: new Groups(['book']))] | ||
| #[ApiProperty(property: 'isbn', serialize: new Groups(['book']))] | ||
| #[ApiProperty(property: 'isbn', serialize: new Groups(['book']))] | ||
| #[ApiProperty(property: 'description', serialize: new Groups(['book']))] |
There was a problem hiding this comment.
@dunglas This part gives me an error when I run php artisan migrate and a fatal error on the API doc, as you can see below:
There was a problem hiding this comment.
I fixed this in core. We just need to update the deps.
There was a problem hiding this comment.
Oh, perfect, so I'll do it in PR #4 👌
There was a problem hiding this comment.
Ready to rebase @dunglas
vinceAmstoutz
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example for api-platform/core#6929