Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update links to use Laravel section references #2138

Open
wants to merge 2 commits into
base: 4.0
Choose a base branch
from

Conversation

sneycampos
Copy link
Contributor

This pull request add the laravel prefix in the laravel section since some anchor links are pointing to the root (symfony) documentation

(ps: i don't know if this fix the links since i think this is automatically generated to site using the gh workflow)

For example in this image, this link: https://api-platform.com/docs/#exposing-a-model should be /docs/laravel#exposing-a-model
image

@alanpoulain
Copy link
Member

Maybe it should be ./#?

@sneycampos
Copy link
Contributor Author

Maybe it should be ./#?

Maybe. Changed to ./#

@vinceAmstoutz
Copy link
Contributor

On GitHub preview it works with the current version (4.0 branch) but you're right it doesn't work for those links on the documentation site (they're generated without the /laravel, so links are broken). I'm guessing it's the code that generates the links, most likely in https://github.com/api-platform/docs-website. @sneycampos @alanpoulain

@dunglas
Copy link
Member

dunglas commented Feb 25, 2025

Shouldn't we fix the docs generator instead of the markdown (which looks good to me)?

@vinceAmstoutz
Copy link
Contributor

Shouldn't we fix the docs generator instead of the markdown (which looks good to me)?

That's exactly what I wanted to say 😄

@sneycampos
Copy link
Contributor Author

There's a relativeURLs = true config in hugo but it broke the entire docs website :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants