fix(symfony): fix for symfony/json_streamer 8.0 with enable_json_streamer #7684
+19
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaa2000
force-pushed
the
fix-symfony-json-streamer-8.0
branch
from
8576f90 to
04bc51b
Compare
aaa2000
force-pushed
the
fix-symfony-json-streamer-8.0
branch
3 times, most recently
from
0d48d5c to
2a481f2
Compare
aaa2000
force-pushed
the
fix-symfony-json-streamer-8.0
branch
from
2a481f2 to
33cbb14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error
@see See the changes on the constructor of Symfony\Component\JsonStreamer\JsonStreamReader symfony/json-streamer@v7.3.0...7.4 and symfony/json-streamer@7.4...v8.0.0
Maybe, it might be better to use the named arguments syntax
The CI was in success because the parameter was defined in the test classes. Introduced in the PR https://github.com/api-platform/core/pull/7561/changes#diff-b81a156503a13943176d13d41ac935fc8b403c698bb839a7b0225747776af476R85