Allow overriding TRUSTED_HOSTS and MERCURE_PUBLIC_URL variables #2666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying the SERVER_NAME to disable HTTPS, as outlined in the API Platform documentation, leads to improper configurations for TRUSTED_HOSTS and MERCURE_PUBLIC_URL when using formats like
http://localhost
or:80
.This results in values like
^:80|php$
or^http://localhost|php$
forTRUSTED_HOSTS
, and URLs such ashttps://:80/.well-known/mercure
orhttps://http://localhost/.well-known/mercure
forMERCURE_PUBLIC_URL
.This PR adopts "nested interpolation" from the Docker documentation to allow precise overrides, introducing
TRUSTED_PROXIES
andCADDY_MERCURE_PUBLIC_URL
as new, adjustable variables, with room for naming discussions.