Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions in requirements.txt and remove deprecated feature #61

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

tofu-rocketry
Copy link
Member

@tofu-rocketry tofu-rocketry commented May 21, 2019

Update Django and rest framework versions in requirements.txt as current versions listed have security vulnerabilities. Also remote patterns() as that is deprecated in this later version.

@gregcorbett
Copy link
Member

related issue #57

@tofu-rocketry
Copy link
Member Author

I couldn't figure out why the unit tests are failing.

@gregcorbett
Copy link
Member

I believe the immediate issue is that in between Django 1.6 and 1.11, patterns has been deprecated and removed.

@tofu-rocketry
Copy link
Member Author

Ah, here's the release notes on that: https://docs.djangoproject.com/en/2.2/releases/1.8/#django-conf-urls-patterns

@tofu-rocketry tofu-rocketry changed the title Update Django version in requirements.txt Update versions in requirements.txt and remove deprecated feature May 30, 2019
@tofu-rocketry
Copy link
Member Author

@tofu-rocketry
Copy link
Member Author

The pagination looks fiddly to fix, so I'm stopping here for the moment. Good news is that the Python 3 build is now failing on the same PaginationSerializer import error!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants