fix: update config-manager related-container image #9544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto Cherry-pick Instructions |
zjx20
approved these changes
Jul 17, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9544 +/- ##
==========================================
+ Coverage 59.76% 59.85% +0.08%
==========================================
Files 518 518
Lines 56320 56324 +4
==========================================
+ Hits 33661 33710 +49
+ Misses 19633 19603 -30
+ Partials 3026 3011 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leon-inf
requested changes
Jul 17, 2025
| @@ -426,6 +427,9 @@ func checkNRollbackProtoImages(itsObj, itsProto *workloads.InstanceSet) { | |||
| if component.IsKBAgentContainer(&c) { | |||
| continue | |||
| } | |||
| if configctrl.IsConfigManagerContainer(c.Name) { | |||
There was a problem hiding this comment.
Do not introduce further dependencies on configuration within the cluster controller.
|
/approve |
apecloud-bot
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.