Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use update instead of patch to set pod's role #8871

Open
wants to merge 2 commits into
base: release-0.9
Choose a base branch
from

Conversation

xuriwuyun
Copy link
Contributor

No description provided.

@xuriwuyun xuriwuyun requested a review from a team as a code owner January 24, 2025 06:12
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Jan 24, 2025
@xuriwuyun xuriwuyun changed the title fix: use update instand of patch to set pod's role fix: use update instead of patch to set pod's role Jan 24, 2025
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.55%. Comparing base (8cf92c7) to head (e011386).

Files with missing lines Patch % Lines
...g/controller/instanceset/pod_role_event_handler.go 77.77% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #8871      +/-   ##
===============================================
+ Coverage        64.40%   64.55%   +0.14%     
===============================================
  Files              359      359              
  Lines            46457    46457              
===============================================
+ Hits             29922    29989      +67     
+ Misses           13841    13787      -54     
+ Partials          2694     2681      -13     
Flag Coverage Δ
unittests 64.55% <77.77%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
1 participant