Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use update instead of patch to set pod's role #8865

Merged
merged 6 commits into from
Feb 6, 2025
Merged

fix: use update instead of patch to set pod's role #8865

merged 6 commits into from
Feb 6, 2025

Conversation

xuriwuyun
Copy link
Contributor

No description provided.

@xuriwuyun xuriwuyun requested a review from a team as a code owner January 23, 2025 10:55
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 23, 2025
@xuriwuyun xuriwuyun linked an issue Jan 23, 2025 that may be closed by this pull request
[BUG] After the restart of the KB controller, when processing the handleRoleChangedEvent event, a disorder issue occurs #8857
Closed
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jan 23, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.49%. Comparing base (851f1b8) to head (ae44817).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...g/controller/instanceset/pod_role_event_handler.go 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8865      +/-   ##
==========================================
+ Coverage   60.16%   60.49%   +0.33%     
==========================================
  Files         382      382              
  Lines       46293    46382      +89     
==========================================
+ Hits        27850    28058     +208     
+ Misses      15771    15643     -128     
- Partials     2672     2681       +9
Flag Coverage Δ
unittests 60.49% <85.71%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 24, 2025
@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 24, 2025
@zjx20 zjx20 changed the title fix: use update instand of patch to set pod's role fix: use update instead of patch to set pod's role Jan 24, 2025
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Feb 5, 2025
@apecloud-bot apecloud-bot added the approved PR Approved Test label Feb 6, 2025
@xuriwuyun xuriwuyun merged commit 24892e7 into main Feb 6, 2025
33 of 35 checks passed
@xuriwuyun xuriwuyun deleted the bugfix/role_event_handler branch February 6, 2025 08:17
@github-actions github-actions bot added this to the Release 0.9.3 milestone Feb 6, 2025
@xuriwuyun
Copy link
Contributor Author

/cherry-pick release-1.0-beta

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/13174555469

apecloud-bot pushed a commit that referenced this pull request Feb 6, 2025
@xuriwuyun
fix: use update instead of patch to set pod's role (#8865)
0f6524b 
(cherry picked from commit 24892e7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Y-Rookie Y-Rookie Y-Rookie approved these changes

@leon-inf leon-inf leon-inf approved these changes

Assignees
No one assigned
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
Release 0.9.3
4 participants
@xuriwuyun @apecloud-bot @Y-Rookie @leon-inf