Skip to content

chore: refactor parameters partV: decouple apps dependence on parameters and tidy up #8620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 27, 2025
Merged

chore: refactor parameters partV: decouple apps dependence on parameters and tidy up #8620

merged 9 commits into from
Feb 27, 2025

Conversation

sophon-zt
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 45.71429% with 228 lines in your changes missing coverage. Please review.

Project coverage is 60.05%. Comparing base (fbe153b) to head (68e5f17).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../component/transformer_component_reload_sidecar.go 22.09% 66 Missing and 1 partial ⚠️
.../parameters/componentdrivenparameter_controller.go 57.85% 49 Missing and 10 partials ⚠️
controllers/parameters/reconcile_task.go 55.55% 28 Missing and 12 partials ⚠️
pkg/controller/render/render_utils.go 0.00% 25 Missing ⚠️
pkg/controller/configuration/template_validate.go 32.14% 19 Missing ⚠️
pkg/controller/configuration/template_render.go 69.23% 8 Missing and 4 partials ⚠️
pkg/controller/configuration/config_utils.go 0.00% 3 Missing ⚠️
pkg/controller/configuration/resource_wrapper.go 0.00% 2 Missing ⚠️
controllers/apps/component/component_controller.go 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8620      +/-   ##
==========================================
- Coverage   60.20%   60.05%   -0.15%     
==========================================
  Files         391      390       -1     
  Lines       46748    46512     -236     
==========================================
- Hits        28145    27935     -210     
- Misses      15875    15893      +18     
+ Partials     2728     2684      -44
Flag Coverage Δ
unittests 60.05% <45.71%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part2 branch from 75ef901 to 0d108f2 Compare December 11, 2024 07:01
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part3 branch from 49d7667 to 6f0dff5 Compare December 11, 2024 07:06
@sophon-zt sophon-zt marked this pull request as ready for review December 11, 2024 08:53
@sophon-zt sophon-zt requested review from leon-inf, Y-Rookie and a team as code owners December 11, 2024 08:53
@sophon-zt sophon-zt marked this pull request as draft December 12, 2024 02:24
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part2 branch from 0d108f2 to 31b29ca Compare December 12, 2024 02:25
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part3 branch 4 times, most recently from 7846fb1 to 7a7d3fe Compare December 13, 2024 09:40
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part2 branch from 4e0d6a2 to 0f9f06e Compare December 25, 2024 05:06
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part3 branch from 7a7d3fe to 001e812 Compare December 25, 2024 05:40
@shanshanying shanshanying added this to the Release 1.0.0 milestone Jan 3, 2025
@github-actions github-actions bot modified the milestones: Release 1.0.0, Release 0.9.3 Jan 14, 2025
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part2 branch from 0f9f06e to 22bb058 Compare February 26, 2025 08:33
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part3 branch from 001e812 to c656190 Compare February 26, 2025 11:00
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part2 branch from 22bb058 to 5cb953e Compare February 27, 2025 02:31
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part3 branch from ede5f89 to bb1bcd2 Compare February 27, 2025 02:42
@sophon-zt sophon-zt marked this pull request as ready for review February 27, 2025 03:03
zjx20
zjx20 previously approved these changes Feb 27, 2025
View reviewed changes
@sophon-zt sophon-zt changed the base branch from support/improvement-parameters-api-part2 to main February 27, 2025 08:53
@sophon-zt sophon-zt dismissed zjx20’s stale review February 27, 2025 08:53

The base branch was changed.

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Feb 27, 2025
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part3 branch from bb1bcd2 to 68e5f17 Compare February 27, 2025 09:04
@apecloud-bot apecloud-bot added the approved PR Approved Test label Feb 27, 2025
@sophon-zt
Copy link
Contributor Author

/approve

@sophon-zt sophon-zt merged commit 6340d2f into main Feb 27, 2025
36 checks passed
@sophon-zt sophon-zt deleted the support/improvement-parameters-api-part3 branch February 27, 2025 11:11
sophon-zt added a commit that referenced this pull request Feb 28, 2025
@sophon-zt
chore: refactor parameters partV: decouple apps dependence on paramet…
f577f6d 
…ers and tidy up (#8620)

(cherry picked from commit 6340d2f)
sophon-zt added a commit that referenced this pull request Feb 28, 2025
@sophon-zt
chore: refactor parameters-related api
1f7f1ab 
commit f577f6d
Author: zhangtao <[email protected]>
Date:   Thu Feb 27 19:11:15 2025 +0800

    chore: refactor parameters partV: decouple apps dependence on parameters and tidy up (#8620)
    
    (cherry picked from commit 6340d2f)

commit ae1fc8a
Author: zhangtao <[email protected]>
Date:   Thu Feb 27 16:36:04 2025 +0800

    chore: refactor parameters partⅣ: parameters-related controller impl (#8619)
    
    (cherry picked from commit fbe153b)

commit deadb91
Author: zhangtao <[email protected]>
Date:   Wed Dec 11 14:42:51 2024 +0800

    chore: refactor parameters partIII: removed deprecated api and tools to do rerender on pods (#8590)
    
    (cherry picked from commit 37f916e)


commit cfc6379
Author: zhangtao <[email protected]>
Date:   Fri Feb 14 17:04:46 2025 +0800

    chore: refactor parameters partI: add parameters group and api (#8582)
    
    (cherry picked from commit fd29cfe)

commit 44abc0b
Author: zhangtao <[email protected]>
Date:   Wed Dec 11 10:51:12 2024 +0800

    chore: refactor parameters partII: refactor template render (#8588)
    
    (cherry picked from commit 248487d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leon-inf leon-inf leon-inf approved these changes

@apecloud-bot apecloud-bot apecloud-bot approved these changes

@zjx20 zjx20 zjx20 left review comments

@Y-Rookie Y-Rookie Awaiting requested review from Y-Rookie

@ldming ldming Awaiting requested review from ldming

@wangyelei wangyelei Awaiting requested review from wangyelei

Assignees
No one assigned
Labels
approved PR Approved Test size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
Release 1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sophon-zt @zjx20 @leon-inf @apecloud-bot @shanshanying