-
Notifications
You must be signed in to change notification settings - Fork 213
feat: support rolling update in the cluster API #8577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
f15db24
feat: support InstanceUpdateStrategy
free6om 95b47a1
rename to RollingUpdate
free6om 02208d3
move&refactor all update related fields into a single struct
free6om 374702c
update stratey constraint
free6om 4f3546d
flattern update strategy in cmpd
free6om 0a07c96
adjust fields name in controllers according to apis
free6om 4692b7b
v1alpha1 <-> v1 conversion
free6om 19b19ba
Merge branch 'main' into support/instance-update-strategy
free6om c47b102
fix staticcheck error
free6om d2c0b28
Merge branch 'main' into support/instance-update-strategy
free6om 7ffb807
remove InstanceUpdatePolicy from cmpd
free6om 48d9c85
support OnDelete update strategy
free6om bcb1635
fix broken ut
free6om 72599d6
Merge branch 'main' into support/instance-update-strategy
free6om eca9492
Merge branch 'main' into support/instance-update-strategy
leon-inf 3b3034b
revert changes to component and sharding definition
leon-inf 362d4ea
revert pod update policy
leon-inf d4fa971
Merge branch 'main' into support/instance-update-strategy
leon-inf ef22954
rename update strategy
leon-inf 7cb8f1f
remove update concurrency from cluster/comp API
leon-inf dc44672
rename and refine
leon-inf d051655
Merge branch 'main' into support/instance-update-strategy
leon-inf d1f1743
rename update strategy in its
leon-inf 0c6a2f8
tidyup
leon-inf 62877c1
remove update concurrency and use member update strategy
leon-inf 4b72127
reuse apps definition
leon-inf cb737ab
fix test
leon-inf 319836f
Merge branch 'main' into support/instance-update-strategy
leon-inf 173fa77
tidyup
leon-inf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for removing MemberUpdateStrategy here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And in the current design, how can we ensure that during the upgrade and deletion process, we first operate on the slave instance and then on the master instance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the Addon has defined roles, it will still be updated according to the roles, the behavior has not changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is a built-in logic, there is no switch that can control it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep.