feat: add addon dependent api and doc #8053
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyrise-l
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
Y-Rookie and
weicao
as code owners
skyrise-l
changed the title
weicao
reviewed
Sep 4, 2024
weicao
reviewed
Sep 4, 2024
Y-Rookie
reviewed
Sep 5, 2024
|
|
||
| // Specify all addons that this addon depends on. | ||
| // +optional | ||
| AddonDependencies []AddonDependency `json:"addonDependencies,omitempty"` |
There was a problem hiding this comment.
What does it mean for a dependency to have an addon's name and version? Based on the issue corresponding to the PR, apecloud-mysql actually depends on a specific version of the etcd cmpd name, but the etcd addon name is not equal to the etcd cmpd name.
skyrise-l
requested review from
michelle-0808,
shanshanying and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7995 An AddonDependencie API has been added to the addon to indicate other addons that the current addon depends on and their supported versions. The version of the dependent addon can be empty, which defaults to the current addon's version.
Slightly later, automatic installation of addon dependencies will be added to kbcli. Currently, only the dependency check for addons is performed in kb.