Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove the dependency on kbcli for KubeBlocks upgrades #7391

Merged
merged 12 commits into from
May 27, 2024
Merged

chore: remove the dependency on kbcli for KubeBlocks upgrades #7391

merged 12 commits into from
May 27, 2024

Conversation

sophon-zt
Copy link
Contributor

No description provided.

@sophon-zt sophon-zt linked an issue May 20, 2024 that may be closed by this pull request
[Features] kb upgrade removes dependence on kbcli #7382
Closed
@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines. label May 20, 2024
@apecloud-bot apecloud-bot requested a review from realzyy May 20, 2024 14:20
@github-actions github-actions bot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels May 21, 2024
@sophon-zt sophon-zt marked this pull request as ready for review May 21, 2024 11:45
@codecov Codecov
Copy link

codecov bot commented May 21, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.33%. Comparing base (c0c4bdf) to head (2a2edad).
Report is 17 commits behind head on main.

❗ Current head 2a2edad differs from pull request most recent head 88de6b7

Please upload reports for the commit 88de6b7 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7391      +/-   ##
==========================================
- Coverage   65.40%   65.33%   -0.07%     
==========================================
  Files         343      343              
  Lines       41636    41649      +13     
==========================================
- Hits        27232    27212      -20     
- Misses      12013    12045      +32     
- Partials     2391     2392       +1
Flag Coverage Δ
unittests 65.33% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

weicao
weicao reviewed May 22, 2024
View reviewed changes
cmd/helmhook/hook/addon.go Outdated Show resolved Hide resolved
weicao
weicao reviewed May 24, 2024
View reviewed changes
cmd/helmhook/main.go Outdated Show resolved Hide resolved
@weicao weicao changed the title kubeblocks upgrade removes dependence on kbcli Remove the dependency on kbcli for KubeBlocks upgrades May 24, 2024
@weicao weicao changed the title Remove the dependency on kbcli for KubeBlocks upgrades chore: remove the dependency on kbcli for KubeBlocks upgrades May 24, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label May 24, 2024
@sophon-zt sophon-zt merged commit 3c7d171 into main May 27, 2024
54 checks passed
@sophon-zt sophon-zt deleted the feature/kb-upgrade-removes-dependence-on-kbcli-issue7382 branch May 27, 2024 07:33
@github-actions github-actions bot added this to the Release 0.9.0 milestone May 27, 2024
@sophon-zt
Copy link
Contributor Author

/cherry-pick release-0.9

@github-actions GitHub Actions
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/9251018747

github-actions bot pushed a commit that referenced this pull request May 27, 2024
@sophon-zt
chore: remove the dependency on kbcli for KubeBlocks upgrades (#7391)
b8edde8 
(cherry picked from commit 3c7d171)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldming ldming ldming approved these changes

@weicao weicao weicao approved these changes

@realzyy realzyy Awaiting requested review from realzyy

@nayutah nayutah Awaiting requested review from nayutah nayutah is a code owner

@heng4fun heng4fun Awaiting requested review from heng4fun heng4fun is a code owner

@free6om free6om Awaiting requested review from free6om free6om is a code owner

@wangyelei wangyelei Awaiting requested review from wangyelei wangyelei is a code owner

@Y-Rookie Y-Rookie Awaiting requested review from Y-Rookie Y-Rookie is a code owner

Assignees
No one assigned
Labels
approved PR Approved Test area/user-interaction size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
Release 0.9.0
Development

Successfully merging this pull request may close these issues.

[Features] kb upgrade removes dependence on kbcli
4 participants
@sophon-zt @ldming @weicao @apecloud-bot