[YUNIKORN-2892] Log correct termination type when releasing task in shim #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuqi-lucas
requested review from
craigcondit,
pbacsko,
wilfred-s and
0yukali0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #917 +/- ##
==========================================
+ Coverage 68.18% 68.19% +0.01%
==========================================
Files 70 70
Lines 7621 7622 +1
==========================================
+ Hits 5196 5198 +2
Misses 2216 2216
+ Partials 209 208 -1 ☔ View full report in Codecov by Sentry. |
pbacsko
reviewed
Sep 30, 2024
craigcondit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Now we will log empty terminate type when releasing task from shim side, we should improve this to consistent with the real terminate type.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2892
How should this be tested?
Screenshots (if appropriate)
Questions: