[YUNIKORN-3036] fix race prevention regression #1014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-instate the change from YUNIKORN-1993 that was reversed as part of YUNIKORN-2658. Add more explicit comment to not move the code. Minor cleanup in function naming and fix the function length of removeAllocation (lint fix) Lint fixes to get make lint to pass locally (*_test.go files)
wilfred-s
requested review from
manirajv06,
chia7712,
craigcondit,
yangwwei and
pbacsko
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1014 +/- ##
=======================================
Coverage 82.68% 82.68%
=======================================
Files 98 98
Lines 15673 15676 +3
=======================================
+ Hits 12959 12962 +3
Misses 2439 2439
Partials 275 275 ☔ View full report in Codecov by Sentry. |
|
looks good. We need to check the reason for e2e test failure, that too only for K8s 1.32.0 |
|
I looked at the last PRs and all fail with the same mention around the scheduler-interface not being available for download. |
craigcondit
pushed a commit
that referenced
this pull request
Mar 6, 2025
Re-instate the change from YUNIKORN-1993 that was reversed as part of YUNIKORN-2658. Add more explicit comment to not move the code. Minor cleanup in function naming and fix the function length of removeAllocation (lint fix) Closes: #1014 Signed-off-by: Craig Condit <[email protected]> (cherry picked from commit 9eee423)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Re-instate the change from YUNIKORN-1993 that was reversed as part of YUNIKORN-2658. Add more explicit comment to not move the code. Minor cleanup in function naming and fix the function length of removeAllocation (lint fix)
Lint fixes to get make lint to pass locally (*_test.go files)
What type of PR is it?
What is the Jira issue?
How should this be tested?
Race condition fix that was in 1.5.x adnd regressed in 1.6.0