Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-3029] update golangci-lint for go 1.23 #1013

Closed
wants to merge 3 commits into from

Conversation

kaichiachen
Copy link
Contributor

What is this PR for?

  1. Bump Go to version 1.23
  2. Update code base to align with the latest lint rules.
  3. deprecate skip-dirs-use-default: WARN [config_reader] The configuration option run.skip-dirs-use-default is deprecated, please use issues.exclude-dirs-use-default.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-3029

How should this be tested?

Make sure

  • make lint
  • make test
    are passed locally

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (5aa780a) to head (549b5e6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1013      +/-   ##
==========================================
+ Coverage   82.66%   82.68%   +0.02%     
==========================================
  Files          98       98              
  Lines       15671    15673       +2     
==========================================
+ Hits        12954    12959       +5     
+ Misses       2441     2439       -2     
+ Partials      276      275       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

craigcondit pushed a commit that referenced this pull request Mar 6, 2025
Closes: #1013

Signed-off-by: Craig Condit <[email protected]>
(cherry picked from commit 621c184)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants