-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2854]Add queue maxRunningApps metrics #1012
Conversation
86a9632
to
f5fa628
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remarks
Please check the failed test case |
Sure @pbacsko I fixed UT issue and updated my change |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1012 +/- ##
=======================================
Coverage 82.48% 82.49%
=======================================
Files 97 97
Lines 15627 15635 +8
=======================================
+ Hits 12890 12898 +8
Misses 2457 2457
Partials 280 280 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
What is this PR for?
Add a new metric - maxRunningApps for Prometheus pull-based monitoring. The
maxapplications
property is an integer value, larger than 1, which allows you to limit the number of running applications for the queue.I fixed the resource name - "Apps" as I see maxRunningApps is a standalone metrics independent from
resources.Resource
. See https://github.com/apache/yunikorn-core/blob/master/pkg/scheduler/objects/queue.go#L86What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2854?filter=-1
How should this be tested?
kubectl port-forward svc/yunikorn-service -n yunikorn 9080:9080
Screenshots (if appropriate)
Questions: